[Bugfix][LoRA] Use an explicit capability flag for tower connector LoRA - #53092
Open
linitra24 wants to merge 1 commit into
Open
[Bugfix][LoRA] Use an explicit capability flag for tower connector LoRA#53092linitra24 wants to merge 1 commit into
linitra24 wants to merge 1 commit into
Conversation
linitra24
requested review from
jeejeelee,
patrickvonplaten,
sighingnow and
vadiklyutiy
as code owners
August 20, 2026 10:15
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
linitra24
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_num_mm_encoder_tokensis defined onSupportsMultiModal, so every model that inherits this interface has the method even if it does not implement it. Therefore, the previoushasattrcheck always returnedTruefor multimodal models and could incorrectly enable tower connector LoRA.Replace the
hasattr(model, "get_num_mm_encoder_tokens")check with an explicitsupports_tower_connector_loracapability flag.Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.